Fix spelling in error message #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I THINK that Talse should be False here. The boolean flips depending on whether we are looking at inline_weights_to_neff or is_weights_neff_separated. It looks like the only time you would get to this is if inline_weights_to_neff is set to True, so the recommendation would b to switch it to False.
JingyaHuang
approved these changes
Jul 17, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the spelling of Talse to False.
I THINK that Talse should be False here. The boolean flips depending on whether we are looking at inline_weights_to_neff or is_weights_neff_separated.
It looks like the only time you would get to this is if inline_weights_to_neff is set to True, so the recommendation would be to switch it to False.
Fixes # (issue)
N/A
Before submitting