Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TGI version and fix bugs #666

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Bump TGI version and fix bugs #666

merged 5 commits into from
Jul 29, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Jul 24, 2024

What does this PR do?

This bumps the TGI router version to 2.1.1 and fixes two issues:

@dacorvo dacorvo marked this pull request as ready for review July 24, 2024 10:07
michaelbenayoun
michaelbenayoun approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits, LGTM!

text-generation-inference/server/text_generation_server/cli.py Outdated Show resolved Hide resolved
text-generation-inference/server/text_generation_server/cli.py Outdated Show resolved Hide resolved
text-generation-inference/server/text_generation_server/cli.py Outdated Show resolved Hide resolved
@dacorvo @michaelbenayoun
review: apply suggestions
acacf55 
Co-authored-by: Michael Benayoun <michael@huggingface.co>
@michaelbenayoun michaelbenayoun merged commit 0332ba6 into main Jul 29, 2024
2 checks passed
@michaelbenayoun michaelbenayoun deleted the bump_tgi_version branch July 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbenayoun michaelbenayoun michaelbenayoun approved these changes

@JingyaHuang JingyaHuang Awaiting requested review from JingyaHuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacorvo @michaelbenayoun