Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS Neuron sdk 2.20 #696

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Use AWS Neuron sdk 2.20 #696

merged 7 commits into from
Sep 19, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Sep 17, 2024

What does this PR do?

This updates optimum-neuron and NeuronX TGI to use AWS Neuron SDK 2.20.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@JingyaHuang
Copy link
Collaborator

For the raised error, @dangdana you could remove the class WeightSeparatedDataParallel since the DP for non-inlined shall have been supported directly from 2.20:

if to_neuron:
if Version(__sdk_version__) >= Version("2.20.0"):
raise NameError(
"`WeightSeparatedDataParallel` class should be deprecated when neuron sdk 2.20 is out. Please replace it with `torch_neuronx.DataParallel`."
)
dp_cls = WeightSeparatedDataParallel
else:

@dacorvo
Copy link
Collaborator Author

dacorvo commented Sep 18, 2024

For the raised error, @dangdana you could remove the class WeightSeparatedDataParallel since the DP for non-inlined shall have been supported directly from 2.20:

if to_neuron:
if Version(__sdk_version__) >= Version("2.20.0"):
raise NameError(
"`WeightSeparatedDataParallel` class should be deprecated when neuron sdk 2.20 is out. Please replace it with `torch_neuronx.DataParallel`."
)
dp_cls = WeightSeparatedDataParallel
else:

Yes, I already fixed it (fyi you pinged someone else ;-) ).

@dacorvo dacorvo marked this pull request as ready for review September 18, 2024 16:33
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this @dacorvo !

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dacorvo !

@dacorvo dacorvo merged commit 39ace4d into main Sep 19, 2024
10 of 12 checks passed
@dacorvo dacorvo deleted the aws_neuron_sdk_2.20 branch September 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants