Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Diffusers pipelines #711

Merged
merged 18 commits into from
Oct 9, 2024
Merged

Refactoring Diffusers pipelines #711

merged 18 commits into from
Oct 9, 2024

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented Oct 7, 2024

What does this PR do?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! Just a small nit, but otherwise LGTM.

@@ -791,7 +894,7 @@ def _export(
batch size during the compilation, but it comes with a potential tradeoff in terms of latency.
output_hidden_states (`bool`, defaults to `False`):
Whether or not for the traced text encoders to return the hidden states of all layers.
data_parallel_mode (`Optional[Literal["none", "unet", "all"]]`, defaults to `None`):
data_parallel_mode (`Optional[Literal["none", "unet", "transformer", "all"]]`, defaults to `None`):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should document this new mode also (although it is not difficult to guess what will happen).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will do that in the next PR for completing the dit support!

@JingyaHuang JingyaHuang merged commit ed7ff12 into main Oct 9, 2024
10 of 12 checks passed
@JingyaHuang JingyaHuang deleted the add-dit-support branch October 9, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants