Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing '=' to assign environment variables in the default case w… #33

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix missing '=' to assign environment variables in the default case w… #33

merged 1 commit into from
May 1, 2024

Conversation

mfuntowicz
Copy link
Member

Looking at the entrypoint.sh for TGI it doesn't have the = operator to assign envvars values if not given by the user

@mfuntowicz mfuntowicz requested a review from tengomucho May 1, 2024 16:17
tengomucho
tengomucho approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@tengomucho tengomucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tengomucho tengomucho merged commit 062180f into main May 1, 2024
1 check passed
@mfuntowicz mfuntowicz deleted the fix-tgi-entrypoint-default-values branch May 1, 2024 20:04
@ManfeiBai
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengomucho tengomucho tengomucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfuntowicz @ManfeiBai @tengomucho