feat(TGI): add release docker image build and push to registry workflow #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengomucho
force-pushed
the
tgi-docker-workflow
branch
15 times, most recently
from
4797e31 to
132f72c
Compare
This will be triggered at each release.
tengomucho
force-pushed
the
tgi-docker-workflow
branch
from
132f72c to
c75a314
Compare
tengomucho
force-pushed
the
tgi-docker-workflow
branch
from
c75a314 to
61c4d42
Compare
oOraph
reviewed
Jun 25, 2024
| labels: ${{ steps.meta.outputs.labels }} | ||
| build-args: | | ||
| VERSION=${{ steps.version.outputs.version }} | ||
| TGI_VERSION=5bc3d65dd32ba1f979540caeccbf3dd8798dd9df |
There was a problem hiding this comment.
Is TGI_VERSION supposed to be frozen here ?
There was a problem hiding this comment.
short answer: yes, for now. Long answer: in the future, TPU TGI development should move into TGI repo, so image building and version will be different. But I guess this should be fine for now.
| labels: ${{ steps.meta-ie.outputs.labels }} | ||
| build-args: | | ||
| VERSION=${{ steps.version.outputs.version }} | ||
| TGI_VERSION=5bc3d65dd32ba1f979540caeccbf3dd8798dd9df |
oOraph
approved these changes
Jun 25, 2024
mfuntowicz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prepares CI to upload TGI image on TPUs.