Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug ModelPatcher returns empty outputs #2109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LoSealL
Copy link

@LoSealL LoSealL commented Dec 1, 2024

When model's output is tuple or list, filtered_outputs doesn't get assigned and hence always a empty dict

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

When model's output is tuple or list, `filtered_outputs`
doesn't get assigned and hence always a empty dict
@LoSealL LoSealL marked this pull request as ready for review December 2, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant