-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for image classification #226
Add support for image classification #226
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!🔥✅ I left a few comments. Mostly regarding breaking backward compatibility.
Other than this awesome PR! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot for adding this @regisss !
Left a few comments, but those are minor stuff, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM(G means great here). :>
Just added some small nits.
Thanks so much for doing this -- really happy to see this feature added 🤗 |
Do not hesitate to show us how you use it :) @davanstrien |
Thank you very much for the great work. The description of this PR mentioned "perform quantization/optimization with computer vision models". Does this include CLIP model (CLIPProcessor, CLIPModel) ? I am looking for an approach to serialize CLIP models (to onnx) and perform quantization/optimization. Any idea how ? @NielsRogge @JingyaHuang |
@rhkenne The first step would be to add ONNX support for CLIP in Transformers. Would you be interested in opening a PR to enable this? Then, for optimization and quantization, additional work would be necessary because multimodal models are not supported yet. |
What does this PR do?
Fixes #173. This PR enables:
At the moment, static post-training quantization with percentile/entropy calibration may not work with some models due to an issue with ONNX Runtime.
Before submitting