Support for custom input shapes in exporters onnx #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
4 tasks
fxmarty
requested review from
mht-sharma,
michaelbenayoun,
regisss and
JingyaHuang
and removed request for
mht-sharma and
michaelbenayoun
|
Let's wait for the stable diffusion PR to be merged before this. |
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
…b.com/fxmarty/optimum into exporters-onnx-variable-inputs-shapes
michaelbenayoun
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Left a few comments, but besides that it looks great, thanks @fxmarty !
| @@ -31,4 +31,4 @@ jobs: | |||
| - name: Test with unittest | |||
| working-directory: tests | |||
| run: | | |||
| RUN_SLOW=1 pytest exporters --durations=0 | |||
| pytest exporters -s --durations=0 | |||
There was a problem hiding this comment.
Are you sure you want to output everything in the log?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be mainly useful for testing, but could also solve temporarily issues on models where the export is dependent on the input shape (for example longformer (but it's actually a bug in PyTorch), and longt5.
Related issues are linked in #503
This PR follows #522
Edit: let's wait for #573 to be merged to clean up
Before submitting