Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates on ONNX config guide #662

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

mszsorondo
Copy link
Contributor

@mszsorondo mszsorondo commented Jan 2, 2023

What does this PR do?

Adds a missing import for BertOnnxConfig
Updates the parameter order of get_exporter_config_constructor and export functions, which were inverted recently.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some styling but looks good to me! Thanks for the fix!

Co-authored-by: fxmarty <9808326+fxmarty@users.noreply.github.com>
@fxmarty fxmarty merged commit e199283 into huggingface:main Jan 3, 2023
@mszsorondo mszsorondo deleted the ONNXConfigGuideUpdate branch January 4, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants