-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PeftMixedModel example #1824
Comments
Indeed, the import is not needed. Are you interested in creating a PR to fix the docstring? |
namanvats
added a commit
to namanvats/peft
that referenced
this issue
Jun 12, 2024
namanvats
added a commit
to namanvats/peft
that referenced
this issue
Jun 12, 2024
Fix PeftMixedModel docstring huggingface#1824
@BenjaminBossan Created a PR to fix the redundant import: #1850 |
namanvats
added a commit
to namanvats/peft
that referenced
this issue
Jun 12, 2024
BenjaminBossan
pushed a commit
that referenced
this issue
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
The
PeftMixedModel
docstring referencesget_peft_model
and imports it in its example but doesn't use it:peft/src/peft/mixed_model.py
Lines 97 to 107 in ad8f7cb
Motivation
The unused import in the docstring is confusing.
Your contribution
Yes.
The text was updated successfully, but these errors were encountered: