TST: Add tests for 4bit LoftQ #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GPU tests for LoftQ with 4bit quantization. Notes Tests for 8bit quantization are already there but not run at the moment, see this comment: huggingface#1150 (comment) In my testing, 8bit passes when using NFQuantizer, so if the original author is fine with using that, I can make the adjustment.
|
@yxli2123 If you could also do a quick review, that would be great. I ran the GPU tests locally and they passed, so 🤞 that they also pass on the nightly CI (PR CI does not run GPU tests). |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
younesbelkada
approved these changes
Dec 5, 2023
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GPU tests for LoftQ with 4bit quantization.
Notes
Tests for 8bit quantization are already there but not run at the moment, see this comment:
#1150 (comment)
In my testing, 8bit passes when using
NFQuantizer, so if the original author is fine with using that, I can make the adjustment.