[core/TPLinear] Fix breaking change
#1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Feb 6, 2024
| @@ -81,6 +81,14 @@ def __init__( | |||
|
|
|||
| self.is_target_conv_1d_layer = False | |||
|
|
|||
| @property | |||
| def is_paralle_a(self): | |||
| # See https://github.com/huggingface/peft/pull/1439 for more details | |||
There was a problem hiding this comment.
Let's add a # TODO remove in version X.Y to these types of deprecations to make it easier to find them in the future.
There was a problem hiding this comment.
Done ! I propose to remove it in 2 minor releases
|
Thank you. I do not speak Python. |
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
* fix breaking change * add comment * add todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1435 (comment)
Fixes a breaking change introduced by #1435
since
is_paralle_ais a public attribute, it is a breaking change to completely remove it as some users might be using it alreadycc @pacman100 @BenjaminBossan