-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: [CI
/ Docker
]: Create a workflow to temporarly build docker images in case dockerfiles are modified
#1481
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@glegendre01 do you think it's ok to move forward with this new workflow? |
Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM, thanks for adding this useful feature.
A minor concern I have is about adding this new GH action. Could it be a possible security concern? Maybe it's a non-issue, it was just something that crossed my mind.
Thanks for the review! |
Also I need to merge this PR before properly testing it as GH does not allow to add new workflow from PRs :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @younesbelkada, nice QoL update for contributors! 🤗
* Update test-docker-build.yml * Update test-docker-build.yml * Update Dockerfile * Update test-docker-build.yml * Update test-docker-build.yml * Update Dockerfile * Update .github/workflows/test-docker-build.yml * Update .github/workflows/test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update .github/workflows/test-docker-build.yml * Update Dockerfile * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * revert * Update .github/workflows/test-docker-build.yml Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com> --------- Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com>
…images in case dockerfiles are modified (huggingface#1481) * test workflow * Update Dockerfile * build docker images * Update .github/workflows/test-docker-build.yml * Update .github/workflows/test-docker-build.yml Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com> --------- Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com>
* Update test-docker-build.yml * Update test-docker-build.yml * Update Dockerfile * Update test-docker-build.yml * Update test-docker-build.yml * Update Dockerfile * Update .github/workflows/test-docker-build.yml * Update .github/workflows/test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update .github/workflows/test-docker-build.yml * Update Dockerfile * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * Update test-docker-build.yml * revert * Update .github/workflows/test-docker-build.yml Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com> --------- Co-authored-by: Guillaume LEGENDRE <glegendre01@gmail.com>
Hi !
I would like to enhance the current way of testing docker build workflow, right now I need to manually change the rules for triggering the build docker image job to test if a PR leads to potential failure on docker build. In this PR I propose to simply trigger a simple workflow that just builds (without pushing) docker images that are modified by a PR
cc @pacman100 @BenjaminBossan