fix: allow load_adapter to use different device #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Could you please run |
|
Hi Benjamin, I just ran |
BenjaminBossan
approved these changes
Apr 10, 2024
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 16, 2024
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the multi-GPU DDP setting, the
load_adapterfunction will always map the state_dict to "cuda", This causes all processes load the parameters to the first GPU, potentially causing OOM error.Changes
Add an optional "torch_device" argument to the
load_adapterfunction, so that by assigning it to "cpu", the parameters will not occupy memory on the first GPU.