Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace base_model's function temporarily #170

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Replace base_model's function temporarily #170

merged 1 commit into from
Mar 14, 2023

Conversation

PanQiWei
Copy link
Contributor

replace base_model.prepare_inputs_for_generation and base_model._prepare_encoder_decoder_kwargs_for_generation temporarily as described in #169

@PanQiWei
changed: 1. replace base_model.prepare_inputs_for_generation and base…
644d68e 
…_model._prepare_encoder_decoder_kwargs_for_generation temporarily
@PanQiWei PanQiWei changed the title Replace base_model's function temporarily1 Replace base_model's function temporarily Mar 10, 2023
@PanQiWei
Copy link
Contributor Author

@pacman100 cc plz 👀

pacman100
pacman100 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PanQiWei for the detailed issue and this PR fixing it, pretty neat, LGTM! 🤗

@pacman100 pacman100 merged commit 3b3fc47 into huggingface:main Mar 14, 2023
@PanQiWei PanQiWei deleted the temporarily_replace_prepare_inputs_for_generation branch May 7, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanQiWei @pacman100