CI Fix Windows permission error on merge test #1952
Merged
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some BS reason, Windows CI suddenly started throwing permission errors on test_merge_layers. These errors occur when using the
TempDirectory()
context manager, which raises aPermissionError
on Windows when it tries to clean up after itself. Therefore, this context manager is now avoided in favor of manual clean up.More context:
I investigated this issue first in #1947. My suspicion that this could be caused by a new pytest version was not confirmed. Maybe the reason is that GH rolled out a new Windows worker, not sure.
Also note that this is not the first time that this workaround is required, e.g. also here:
peft/tests/test_custom_models.py
Lines 1448 to 1467 in e6cd24c