-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and examples for X-LoRA #1970
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Looks good so far: https://moon-ci-docs.huggingface.co/docs/peft/pr_1970/en/package_reference/xlora Btw. did you join HF? |
Yes! |
Ha, very nice! Didn't see any announcement yet. Welcome on board.
Nice. LMK when this is ready for review (won't have time today but will check tomorrow). |
Hi @BenjaminBossan! I think this should be ready for a review of the docs. I haven't added training examples yet, but I added one for mistralrs - do you think that's good or should we just add a link? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the detailed docs. There isn't much to add from my side, just a few smaller comments.
I think it would still be great to have a training example to accompany the mistralrs inference example.
Please always ping me when the PR is ready for review. |
@BenjaminBossan it should be ready now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the documentation for X-LoRA. LGTM.
Thanks! I'll add the training example in a later PR. |
May I ask when will the training example be published? |
Adds docs for X-LoRA as well as examples: