Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error message when users pass layers_to_transform and layers_pattern #2164

Closed
wants to merge 5 commits into from

Conversation

JINO-ROHIT
Copy link
Contributor

This tries to add some verbose message when users pass layers_to_transform and layers_pattern addressing point 3 in #2155.

@BenjaminBossan
Copy link
Member

@JINO-ROHIT Please let me know if the PR is ready for review (always ping me if it's ready).

@JINO-ROHIT
Copy link
Contributor Author

Hi @BenjaminBossan yeap this is ready for review, im not sure why the other PR commits are being displayed here

@BenjaminBossan
Copy link
Member

Wait, how is this PR different from #2159?

@JINO-ROHIT
Copy link
Contributor Author

yeah actually #2159 simply adds the check if

if self.layers_to_transform is not None and self.layers_pattern is None:
            raise ValueError(
                "When `layers_to_transform` is specified, `layers_pattern` must also be specified. "
            )

This PR is making the error message better logging for layers_transform and layers_pattern if specified, this commit basically - 1f26074

Looks weird that the other commits are being shown here

@BenjaminBossan
Copy link
Member

Looks weird that the other commits are being shown here

Yes, I can't really review this PR because of that. Probably it's easiest to just open a new PR and ensuring it only contains the commit intended for that PR.

@JINO-ROHIT
Copy link
Contributor Author

sure

@JINO-ROHIT JINO-ROHIT closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants