[utils] add merge_lora utility function
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
requested review from
pacman100
and removed request for
pacman100
|
This PR is now ready for review! all tests are passing |
younesbelkada
commented
Mar 29, 2023
pacman100
reviewed
Mar 30, 2023
There was a problem hiding this comment.
Thank you @younesbelkada for adding this feature which resolves many issues related to merging the lora params back into the base model without any wrappers on it.✨
Left a couple of comments and suggestions
| @@ -233,6 +238,34 @@ def enable_adapter_layers(self): | |||
| def disable_adapter_layers(self): | |||
| self._set_adapter_layers(enabled=False) | |||
|
|
|||
| def merge_and_unload(self): | |||
There was a problem hiding this comment.
This would not work when the model is loaded in 8bit. An assertion error for the same would be helpful.
There was a problem hiding this comment.
Thanks for the pointer! added a check for that
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
…into add-merge-lora
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
pacman100
approved these changes
Mar 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new utility function
merge_lorato conveniently merge lora layers into the base model, so that users can use this model as a standalonetransformersmodelAdded also some tests (that are currently failing)
cc @pacman100