[CI] Pin diffusers
#936
Merged
[CI] Pin diffusers
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacman100
approved these changes
Sep 15, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
4 tasks
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Oct 18, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it. This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub: > ImportError: cannot import name 'cached_download' from 'huggingface_hub'
BenjaminBossan
added a commit
that referenced
this pull request
Oct 18, 2024
The pin was added way back in #936 and then we forget to ever remove it. This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub: > ImportError: cannot import name 'cached_download' from 'huggingface_hub'
sirluk
pushed a commit
to sirluk/peft
that referenced
this pull request
Oct 19, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it. This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub: > ImportError: cannot import name 'cached_download' from 'huggingface_hub'
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it. This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub: > ImportError: cannot import name 'cached_download' from 'huggingface_hub'
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it. This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub: > ImportError: cannot import name 'cached_download' from 'huggingface_hub'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the current failing CI by pinning diffusers to before 0.21
The 0.21 version introduced a new way to load and run lora layers, and also introduced the
scaleparameter for forward pass. As this behaviour seems to break inference with PEFT, let's pin diffusers version and wait for the more global diffusers + peft integration coming sooncc @pacman100 @BenjaminBossan