New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `Cargo.lock` (again) #470

Closed

9999years wants to merge 1 commit into huggingface:main from 9999years:main

9999years commented Apr 18, 2024

Cargo.lock files were added in #229 and then removed about a month later in #253 (with the justification that "cargo.lock messes up benchmarks").

Shortly after, the Rust project guidance was updated to encourage committing lockfiles:

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control rust-lang/cargo#8728

Let's add the lockfiles back to make builds reproducible and deterministic, especially for consumers of Python bindings.


          Add Cargo.lock (again)

649fdd8

`Cargo.lock` files were added in huggingface#229 and then removed about a month
later in huggingface#253 (with the justification that "cargo.lock messes up
benchmarks").

Shortly after, the Rust project guidance was updated to encourage
committing lockfiles:

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
rust-lang/cargo#8728

Let's add the lockfiles back to make builds reproducible and
deterministic, especially for consumers of Python bindings.

github-actions bot added the Stale label

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels