add more loss function options #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipMay
changed the title
PhilipMay
changed the title
|
CI is green, this is done and can be merged from my point of view. |
lewtun
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Thanks for adding these additional args @PhilipMay 🤗 !
I think at some point we'll need to refactor this out to a dedicated class for the training args (like the transformers.Trainer), but happy to have this included for now :)
Should we collect this "future ideas" anywhere? |
PhilipMay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more options to the non default loss functions.
This is
distance_metricandmargin.The default values are selected in a way that this is no breaking change.
Todo