No longer needlessly deepcopy the original model state #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199
Hello!
Pull request overview
deepcopy
ofmodel.state_dict
.scripts/setfit/run_fewshot_multilabel.py
to reflect thatmodel.model_original_state
has been removed.Details
As mentioned by @Yongtae723 in #199, the model state is copied and then never used again, with exception of
scripts/setfit/run_fewshot_multilabel.py
. This is an unnecessary waste of memory, and hence we believe that these lines should be removed.Furthermore, I modified
scripts/setfit/run_fewshot_multilabel.py
to perform the deepcopying in that script itself. Note that this is somewhat different than the original situation, as now these two lines are executed before the deepcopying is performed, rather than the deepcopy occurring first:setfit/src/setfit/modeling.py
Lines 47 to 48 in b66760c
I suspect that this won't matter too much, but I'll leave that up to your judgement.
The script still works like before, e.g. using: