-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of OpenVINO export #214
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@AlexKoff88
|
Hi Tom, I've revised the code according to the recent changes and your suggestions. Please check again. |
Hello @AlexKoff88, I think we're moving in the right direction with these recent changes, but there are some issues still. Beyond that, the CI is complaining about code quality. That can be resolved by running
|
Hi, I cleaned up the style. OpenVINO 2022.3 is essential. I am ok to postpone the merge 1-2 weeks before it is available on PyPI. |
@tomaarsen, OpenVINO 2022.3 is available and OpenVINO export should work now. Please merge. |
@AlexKoff88 I still have some tiny nits on the notebook that you've provided. Thanks a lot for it, by the way, it helps users out a lot. |
Thanks, @tomaarsen. I've updated the notebook according to your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for this PR and for following up on our requests. Happy new year!
Thanks for accepting the contribution! And Happy New Year! |
PR content: