Revert "Add SetFitModel.to" #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e29486f.
Merged
|
I looked into this briefly. It seems like this is an issue with the Python dependency caching that I introduced in #233, rather than an issue with #229. All of the CI runs that loaded the cache threw an error, and the few runs that had to reinstall the dependencies worked as intended. I'll look into it. To be concrete: #229 is safe and this CI issue does not negatively affect a release.
|
tomaarsen
added a commit
to tomaarsen/setfit
that referenced
this pull request
Dec 14, 2022
To prevent the issue described at huggingface#234 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #229 due to failing CI on
maincc @tomaarsen