Reintroduce SetFitModel.to
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SetFitModel.to * Add docstring for 'to' to clarify that we don't copy Note that this does mean that we differ from e.g. torch, which creates a moved copy rather than moving the e.g. tensor itself to a different device. * Add tests for 'to'. If CUDA is available, then try to move a model from the CPU to the GPU and back to the CPU. * Reformat test_modeling Co-authored-by: Tom Aarsen <Cubiegamedev@gmail.com>
lewtun
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Thanks for re-opening the PR @tomaarsen and apologies to @jegork for thinking it was your PR that caused the CI to break.
This looks great, so merging now - thanks again @jegork !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request Overview
Details
The merge commit implementing #229 had to be reversed due to test failures. However, the test failures were caused by another issue, described in #235. The changes from this PR should be safe. As a result, it was requested to reintroduce these changes.
Apologies for the mess surrounding the test failures.