-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyo3: update to 0.20 #1386
pyo3: update to 0.20 #1386
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Thanks for opening the PR and sorry for missing it |
@ArthurZucker @mikelui -- would it be possible to re-open the PR and merge it in? It looks like it got closed as stale but was not actually merged (at least https://github.com/huggingface/tokenizers/blob/main/bindings/python/Cargo.toml#L17 still points to 0.19) |
I planned on updating this before end of week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ArthurZucker for confirmation.
@mikelui what is missing here ? |
nothing, just wanted to check if there were any tangible changes that would affect merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me thanks!
PyDict::get_item
which now returns aPyResult<Option<&PyAny>>
instead ofOption<&PyAny>