Fix unsoundness in tokenizers::utils::parallelism
#1492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static variable `USED_PARALLELISM` was previously modified and accessed in safe functions with no guarantee of soundness. This is fixed by putting it into a Mutex.
albertsgarde
changed the title
tokenizers::utils::parallelism
|
Hey sorry for the delay I'll try to review for next week! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@ArthurZucker I think #1532 is a superior solution, so this PR should probably just be closed |
|
Thanks a lot for this PR and fixing the unsoundness (unsafe). This PR seems even slightly better using Atomic instead (which are lock-free).#1532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1491 by turning
static mut USED_PARALLELISM: boolinto aMutex, i.e.static USED_PARALLELISM: Mutex<bool>. This allows the value to be accessed and modified safely and avoids unsoundness. There is a slight performance penalty, but given that the variable is only modified in the context of other parallel work, it is almost certainly negligible.This PR fails several tests, but only the tests
mainalso fails.