Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more support for tiktoken based tokenizers #1493

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Conversation

ArthurZucker
Copy link
Collaborator

Adds a check before using merges, returing the token if it is part of the vocab

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker marked this pull request as ready for review April 15, 2024 13:27
@ArthurZucker ArthurZucker requested a review from Narsil April 15, 2024 13:31
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM preemptively.

Not sure about this name (even if I agree it definitely looks like a bug.)

ArthurZucker and others added 5 commits April 15, 2024 16:05
Copy link
Collaborator Author

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright finalized

@ArthurZucker ArthurZucker merged commit 914576f into main Apr 15, 2024
12 checks passed
@ArthurZucker ArthurZucker deleted the update-bytelevel branch April 15, 2024 15:26
ArthurZucker added a commit that referenced this pull request Apr 15, 2024
* first commit

* update

* clippy

* lint

* clippy and lint

* fmt

* revert print

* 😈

* style

* add a test

* more fmt

* Use ignore_merges

* stub

* fix

* update

* Update tokenizers/src/models/bpe/model.rs

Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>

* update

* rust lint

* dob; t repeat yourself

---------

Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants