Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from cached_download to hf_hub_download in tests #1547

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 6, 2024

Small PR to switch from the legacy cached_download to hf_hub_download in tests. Doesn't impact the lib' itself.

(somehow related to huggingface/huggingface_hub#2317)

@Wauplin Wauplin requested review from Narsil and ArthurZucker June 6, 2024 10:23
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin changed the title Switch from cached_download to hf_hub_download in tests Switch from cached_download to hf_hub_download in tests Jun 6, 2024
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you just rebase, should fix the CI

@Wauplin
Copy link
Contributor Author

Wauplin commented Jun 10, 2024

@ArthurZucker Thanks for the review :)

Can you just rebase, should fix the CI

Done ✔️

@Wauplin Wauplin merged commit 88f51fe into main Jun 11, 2024
11 checks passed
@Wauplin Wauplin deleted the remove-deprecated-cached-download branch June 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants