make sure we don't warn on empty tokens #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
4 tasks
McPatate
approved these changes
Jun 19, 2024
Comment on lines
+236
to
+245
| #[cfg(feature = "http")] | ||
| #[test] | ||
| fn test_from_pretrained() { | ||
| fmt() | ||
| .with_max_level(tracing::Level::DEBUG) | ||
| .with_target(false) | ||
| .init(); | ||
| let _ = Tokenizer::from_pretrained("Qwen/Qwen2-7B-Instruct", None); | ||
| warn!("This should be the first warning"); | ||
| } |
There was a problem hiding this comment.
What is the purpose of this test?
|
Will fix clippy on main and merge! |
ArthurZucker
added a commit
that referenced
this pull request
Jul 12, 2024
* make sure we don't warn on empty tokens * Testing the log is actually hard 😓 * mpty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activating warnings, there was an issue with added tokens that are not part of the vocab. I am pretty sure that the main point about added tokens is that they don't have to be in the vocab, so fixing this.