Bump spm_precompiled to 0.1.3 #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Ant chance the Node / check is a spurious failure, or unrelated to this pr? |
|
Could you rebase on main? If it keeps failing it means it's probably incompatible |
|
Rebased |
Narsil
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands now using spm_precompiled < 0.1.3 will result in the build of tokenizers failing.
While by default cargo will pick the newest available version for all dependencies, if a user has not run
cargo updatein a while they can still have older versions in their lock file.This error can be reproduced by running
rustup run nightly cargo update -Zminimal-versions && cargo --locked check, creating a lock file with minimal versions of all dependencies allowed by Cargo.toml.It may also be a good idea to add such a check to the CI, if you think this would be a valuable addition, let me know, and I'll be happy to do it.