Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using serde (serde_pyo3) to get __str__ and __repr__ easily. #1588

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Aug 2, 2024

Dummy implementation everywhere, but it's a showcase.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fu**ng amazing 🚀 Instead of deriving at compile time a display function for each and every single class in rust, we just rely on the already derived Serialize trait, which give obj.serialize(). so smart, really thanks for finding a much more elegant solution thant #1542

@Narsil Narsil merged commit ab9c7de into main Aug 7, 2024
12 checks passed
@Narsil Narsil deleted the serde_pyo32 branch August 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants