Improve decoder deserialization #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Narsil
force-pushed
the
improve_decoder_deserialization
branch
from
eada410 to
e28016c
Compare
ArthurZucker
approved these changes
Aug 6, 2024
| @@ -98,7 +208,7 @@ mod tests { | |||
| match parse { | |||
| Err(err) => assert_eq!( | |||
| format!("{err}"), | |||
| "data did not match any variant of untagged enum DecoderWrapper" | |||
| "data did not match any variant of untagged enum DecoderUntagged" | |||
There was a problem hiding this comment.
We could change the custom to properly output decoder wrapper
There was a problem hiding this comment.
I think the new message is better, since Untagged is more descriptive than wrapper (both mean nothing to regular users, but at least untagged points to the fact that the type is missing.
We can override the message as needed. Do you have a good suggestion for the message?
There was a problem hiding this comment.
Out of the box, something like "The type field is not present and we could not load into any of the variants of DecoderUntagged"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the actual error message when
typeis present, but fields are invalid.