Arg name correction: auth_token -> token #1621
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
LGTM, thanks!
cc @ArthurZucker for a quick review (this fixes huggingface/transformers#33183)
|
Ah ok, sorry! I think this is the Rust file that should be updated then tokenizers/bindings/python/src/tokenizer.rs Line 593 in 14a07b0 |
|
.rs updated. Re-iterating my my bug report: I'm new here, don't know Rust, don't have the doc build env set up. |
|
@ArthurZucker could you check whether the rust code has been updated? It would be nice to merge this 🤗 thanks |
| if let Some(auth_token) = auth_token { | ||
| kwargs.set_item(intern!(py, "token"), auth_token)?; | ||
| if let Some(token) = token { | ||
| kwargs.set_item(intern!(py, "token"), token)?; | ||
| } | ||
| let path: String = hf_hub_download.call((), Some(&kwargs))?.extract()?; |
There was a problem hiding this comment.
we just pass the kwargs to the hf_hub_download api, so IMO this is fine!
|
@rravenel do you want me to do it? |
|
Sure - thanks.
…On Tue, Oct 1, 2024 at 5:09 AM Arthur ***@***.***> wrote:
@rravenel <https://github.com/rravenel> do you want me to do it?
—
Reply to this email directly, view it on GitHub
<#1621 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATIILR2ZVD5QZ7BQSNZEODZZKGJFAVCNFSM6AAAAABNK64IFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBVGYYDQMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ArthurZucker
force-pushed
the
doc_from_pretrained
branch
from
b6e03d7 to
15a36c3
Compare
|
hi @ArthurZucker, is this ready to be merged so we can close huggingface/transformers#33183? |
|
Yep Merging, this will be in 0.21.0 |
Simple correction.