Fix encode_batch and encode_batch_fast to accept ndarrays again #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@ArthurZucker mind giving this a look since I think sooner than later someone is going to complain about |
ArthurZucker
approved these changes
Nov 18, 2024
|
(Sorry about the delay we were on a company wide offsite 😅 🌴 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Could you update with clippy as well? 🤗 |
diliop
commented
Nov 20, 2024
| @@ -152,8 +152,6 @@ def test_encode(self): | |||
| assert len(output) == 2 | |||
|
|
|||
| def test_encode_formats(self, bert_files): | |||
There was a problem hiding this comment.
@ArthurZucker there are already a set of tests covering np.array - did you have something else in mind?
There was a problem hiding this comment.
Nope I checked and found then so approved and good to go!
|
Thanks! 🤗 |
ArthurZucker
pushed a commit
that referenced
this pull request
Nov 26, 2024
* Fix encode_batch and encode_batch_fast to accept ndarrays again * Fix clippy --------- Co-authored-by: Dimitris Iliopoulos <diliopoulos@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to my comment from here which essentially reverts the
PyListchange from #1665 andPySequencechange from #1673 with regards to theinputarg forencode_batchandencode_batch_fast, back toVec<..>. This allows passingndarraytogether withlistandtupleasinputtypes. I also turned on the tests that were turned off before to make sure that this change forencode_batchis covered. I will follow up with adding more tests forencode_batch_fastbut prefer to get this out sooner than later.