Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): add missing scale element #1017

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tosinamuda
Copy link
Contributor

Fixes bug: Uncaught TypeError: Cannot read properties of null (reading 'addEventListener') at main.js:38:13

Cause

While scaleSlider and scaleLabel are defined in main.js, there are missing in the index.html dom

const scaleSlider = document.getElementById('scale');
const scaleLabel = document.getElementById('scale-value');

This leads to a uncaught error which doesn't allow the example to work in the line below:

// Set up controls
let scale = 0.5;
scaleSlider.addEventListener('input', () => {
    scale = Number(scaleSlider.value);
    setStreamSize(video.videoWidth * scale, video.videoHeight * scale);
    scaleLabel.textContent = scale;
});
scaleSlider.disabled = false;

In main.js, scaleSlider is needed which result into an undefined error
Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Even though we are moving our examples to https://github.com/huggingface/transformers.js-examples/, this is a good thing to fix :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@xenova xenova merged commit 82bae5e into huggingface:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants