Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier command manually once and automatically on CI #1043

Closed
wants to merge 4 commits into from

Conversation

pdufour
Copy link
Contributor

@pdufour pdufour commented Nov 20, 2024

I noticed that there is a prettier config, but it doesn't look like the command has been ran in a while, so there are a lot of fixes applied when I run it. Therefore, I did the following:

  1. manually ran it once
  2. and also added a CI check step that will automatically check PR's with format:check

You may get some merge conflicts on PR's when / if this is merged, so for that I recommend the following steps:

Rebase steps

  • On your branch
  • git checkout main -- .prettierrc (I just made a minor change to max line length to align with existing code)
  • npm run format
  • Then merge in main, that way both files will be formatted and you shouldn't have issues

Test Plan

@xenova
Copy link
Collaborator

xenova commented Nov 20, 2024

Hi there 👋 It was intentional to not yet run prettier until some open PRs had been merged (to keep the diffs small). So, while I won't merge this PR as is, I do think the .github/workflows/format-check.yml can be useful once we do. Is this something you can extract into a separate PR? Thanks!

@pdufour pdufour mentioned this pull request Nov 20, 2024
@pdufour
Copy link
Contributor Author

pdufour commented Nov 20, 2024

Hi, thanks for the quick response! Done - #1044.

@pdufour pdufour closed this Nov 20, 2024
@xenova
Copy link
Collaborator

xenova commented Nov 20, 2024

Amazing! Thanks so much! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants