Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate accelerate.mdx from english to spanish #16176

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Translate accelerate.mdx from english to spanish #16176

merged 5 commits into from
Mar 31, 2022

Conversation

Sangohe
Copy link
Contributor

@Sangohe Sangohe commented Mar 15, 2022

What does this PR do?

Add the spanish version of accelerate.mdx to transformers/docs/source_es

Fixes #15947 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

@omarespejel @osanseviero

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 15, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@omarespejel omarespejel self-requested a review March 16, 2022 05:07
@omarespejel
Copy link
Contributor

Thanks, @Sangohe! I will review it during the week :)

omarespejel
omarespejel suggested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@omarespejel omarespejel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias! I left some simple comments.

docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
Sangohe and others added 2 commits March 17, 2022 23:23
@Sangohe @omarespejel
Update docs/source_es/accelerate.mdx
a6d87e1 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@Sangohe @omarespejel
Apply suggestions from code review
b2c10c8 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@Sangohe
Copy link
Contributor Author

Sangohe commented Mar 18, 2022

Muchas gracias! I left some simple comments.

Thank you for your comments. I've added all the suggestions and committed the new version

omarespejel
omarespejel suggested changes Mar 24, 2022
View reviewed changes
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
docs/source_es/accelerate.mdx Outdated Show resolved Hide resolved
@Sangohe @omarespejel
Apply suggestions from code review
7df25e2 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@Sangohe
Copy link
Contributor Author

Sangohe commented Mar 26, 2022

Thanks again for the review. I've committed the last suggestions.

@omarespejel
Copy link
Contributor

Thank you @Sangohe! 🤗

@sgugger LGTM 👍

sgugger
sgugger approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR!

@sgugger sgugger merged commit 6a4dbba into huggingface:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarespejel omarespejel omarespejel approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish
4 participants
@Sangohe @HuggingFaceDocBuilderDev @omarespejel @sgugger