Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX function refactor #17625

Merged

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

This PR just refactors some pieces of code that are useful in symbolic_trace so that they can be used as standalone functions, and in other libraries, for instance here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@michaelbenayoun michaelbenayoun requested a review from sgugger June 14, 2022 13:52
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/transformers/utils/fx.py Outdated Show resolved Hide resolved
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@michaelbenayoun michaelbenayoun merged commit 7ec9128 into huggingface:main Jun 14, 2022
@michaelbenayoun michaelbenayoun deleted the fx_function_refactor branch June 14, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants