Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean modeling utils, linked to #17760 and #17713 #17818

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

The recently introduced TF and FLAX sharding scripts #17760 and #17713 both use convert_file_size_to_int, get_checkpoint_shard_files, which were moved to transformers.utils.hub. This PR just removed the definition of these two function and imports them form transformers.utils.hub

@ArthurZucker ArthurZucker changed the title Flax sharded (#17760) Clean modeling utils, linked to #17760 and #17713 Jun 22, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 22, 2022

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker requested review from sgugger and patrickvonplaten and removed request for sgugger June 22, 2022 07:34
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@ArthurZucker ArthurZucker merged commit 56b83cf into huggingface:main Jun 22, 2022
@ArthurZucker ArthurZucker deleted the clean-modeling-utils branch June 22, 2022 12:45
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 25, 2022
younesbelkada pushed a commit to younesbelkada/transformers that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants