-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin torch to use 1.12.1 #18514
unpin torch to use 1.12.1 #18514
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Here are the tests to fix before we can use 1.12.1
|
Most tapas tests will likely work given @sgugger's PR above, as it's probably linked to the version of the torch-scatter dependency |
Yes! Thanks, @LysandreJik |
(guess I can close this PR, and just merge #17925) |
@@ -187,6 +187,8 @@ def backward(ctx, grad_output): | |||
|
|||
@staticmethod | |||
def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
from torch.onnx import symbolic_opset12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this line, we get (for torch 1.12.x
):
FAILED tests/onnx/test_onnx_v2.py::StableDropoutTestCase::test_training - AttributeError: module 'torch.onnx' has no attribute 'symbolic_opset12'
@@ -193,6 +193,8 @@ def backward(ctx, grad_output): | |||
|
|||
@staticmethod | |||
def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
from torch.onnx import symbolic_opset12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just applied the same change
@@ -597,6 +597,8 @@ def backward(ctx, grad_output): | |||
|
|||
@staticmethod | |||
def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
from torch.onnx import symbolic_opset12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
Can you push necessary changes directly on #17925 (I'm too lazy to check this PR contains the same fixes as this one 😅 ) The branch is |
Close this and work on #17925 instead |
What does this PR do?
unpin torch to use 1.12.1