Fixed the docstring and type hint for forced_decoder_ids option in Ge… #19640
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerationMixin.generate to be consistent with the actual implementation
|
The documentation is not available anymore as the PR was closed or merged. |
gante
reviewed
Oct 17, 2022
sgugger
approved these changes
Oct 17, 2022
|
@gante Thanks for the comment! I've taken in your suggestion in the new commit. Please proceed with the merge if it is looking good. |
|
@koreyou Awesome, thank you for the changes! I will merge as soon as CI turns to green :) |
gante
approved these changes
Oct 17, 2022
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #19602 where the docstring and type hint for forced_decoder_ids option in GenerationMixin.generate were inconsistent with the actual implementation.
Fixes #19602
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@gante has suggested me to send a PR for the issue #19602.