Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation of multiple_choice.mdx, question_answering.mdx. #19821

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Spanish translation of multiple_choice.mdx, question_answering.mdx. #19821

merged 5 commits into from
Oct 25, 2022

Conversation

alceballosa
Copy link
Contributor

What does this PR do?

Translates multiple_choice.mdx and question_answering.mdx into Spanish. Also updates the _toctree.yml file accordingly.

Fixes #15947

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

@osanseviero @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 23, 2022

The documentation is not available anymore as the PR was closed or merged.

@osanseviero osanseviero self-requested a review October 24, 2022 09:25
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! @osanseviero feel free to merge if you're happy with this PR :-)

Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this is very cool and great translation!

docs/source/es/_toctree.yml Outdated Show resolved Hide resolved
docs/source/es/tasks/question_answering.mdx Outdated Show resolved Hide resolved
docs/source/es/tasks/question_answering.mdx Outdated Show resolved Hide resolved
@alceballosa
Copy link
Contributor Author

Thanks @osanseviero, I just updated all files to reflect your suggestions :)

@osanseviero
Copy link
Member

Thanks a lot! 🔥

@sgugger sgugger merged commit 371337a into huggingface:main Oct 25, 2022
@alceballosa alceballosa deleted the docs-spanish-question-answering-multiple-choice branch October 25, 2022 00:12
@alceballosa
Copy link
Contributor Author

@sgugger thanks for the merge! However, shouldn't the original issue (#15947) addressing the translations remain open? Think it was closed automatically bc I referenced it here.

@sgugger
Copy link
Collaborator

sgugger commented Oct 25, 2022

Yes, that's because you used the word "Fixes". You should have said something like "Related to ..." :-)

@alceballosa
Copy link
Contributor Author

Oops, sorry! Lesson learned :')

amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Nov 1, 2022
…uggingface#19821)

* Translated multiple_choice.mdx, question_answering.mdx. Added them to _toctree.yml

* Added translation for a missed line.

* Update _toctree.yml as per Omar's suggestions

* Update multiple_choice.mdx as per Omar's comments

* Updt question_answering.mdx as per Omar's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish
4 participants