Clarify use_fast parameter in docstring
#20840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
approved these changes
Dec 19, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
Hmm that's a good question! Do you happen to know if any of the other architectures have this issue or if it is just a bug with OPT? I'll remove the suggestion to check the supported framework list so we don't end up confusing anyone. |
|
It's the first time I run into this inconsistency across models of the same arch, but I have never needed to ensure it was So +1 to remove the suggestion unless we somehow can stand behind it. |
|
This was the bug for OPT, so it shouldn't happen for other models. |
LysandreJik
approved these changes
Dec 20, 2022
MKhalusova
pushed a commit
to MKhalusova/transformers
that referenced
this pull request
Dec 28, 2022
* clarify use_fast parameter * make style * remove check frameworks, apply review
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jan 4, 2023
* clarify use_fast parameter * make style * remove check frameworks, apply review
silverriver
pushed a commit
to silverriver/transformers
that referenced
this pull request
Jan 6, 2023
* clarify use_fast parameter * make style * remove check frameworks, apply review
venkat-natchi
pushed a commit
to venkat-natchi/transformers
that referenced
this pull request
Jan 22, 2023
* clarify use_fast parameter * make style * remove check frameworks, apply review
miyu386
pushed a commit
to miyu386/transformers
that referenced
this pull request
Feb 9, 2023
* clarify use_fast parameter * make style * remove check frameworks, apply review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the ambiguity of the
use_fastparameter raised in #20817.