Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated title of fast_tokenizer to test PR #22615

Closed
wants to merge 2 commits into from
Closed

Translated title of fast_tokenizer to test PR #22615

wants to merge 2 commits into from

Conversation

kihoon71
Copy link
Contributor

@kihoon71 kihoon71 commented Apr 6, 2023

What does this PR do?

Firstly, sorry for late PR, and From this week i can handle rest of the task. so Next this kind of thing will not happen again.

I did translate the title of fast_tokenizers.mdx.

Part of #20179

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @wonhyeongseo , @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@gabrielwithappy
Copy link
Contributor

gabrielwithappy commented Apr 7, 2023

Dear @kihoon71 ,

  1. Please remove "Fixes # (issue)" on the decription.
  2. Please add [WIP] on the title or change to draft status.
    Then reivewers can check this PR is now in-progress. :-)
    BRs.

@kihoon71 kihoon71 closed this by deleting the head repository Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants