Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_disk_offload for WhisperModelTest #22803

Closed
wants to merge 1 commit into from
Closed

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 17, 2023

What does this PR do?

Since #22486, WhisperModelTest.test_disk_offload to fail. I just blindly skip this test and guess it is ok.....?

@ydshieh ydshieh requested a review from sgugger April 17, 2023 11:44
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be worth investigating more, e.g. is it working for big models (cc @ArthurZucker ).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 17, 2023

I am not able to use openai/whisper-base as I get GPU OOM. When I tried to use openai/whisper-tiny.en, I have a hard time to change the parameters to get a working input dict for the model.

If I just changed the values in model tester to get a larger model (but random), I get different kinds of error like IndexError: list index out of range in dispatch_model or RuntimeError: Tensor on device meta is not on the expected device cuda:0! in model forward.

But even if I revert the change in #22486, the above attempts to use larger (fake) models still have the same issue. I guess we will have to look into this.

@ydshieh ydshieh marked this pull request as draft April 17, 2023 15:43
@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 17, 2023

Convert to draft to avoid being merged.

@huggingface huggingface deleted a comment from github-actions bot May 25, 2023
@hollance hollance mentioned this pull request May 25, 2023
5 tasks
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@ydshieh ydshieh closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants