-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to explain disabling callbacks using report_to #26155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good to me
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is great!
As part of this, can we update https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#L2385-L2388 to basically be a repeat of https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#L522-L526? Otherwise LG2M as well :)
@muellerzr sure! Just pushed that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phenomenal! Good to go on my side then
…ce#26155) * feat: update callback doc to explain disabling callbacks using report_to * docs: update report_to docstring
…ce#26155) * feat: update callback doc to explain disabling callbacks using report_to * docs: update report_to docstring
…ce#26155) * feat: update callback doc to explain disabling callbacks using report_to * docs: update report_to docstring
What does this PR do?
Fixes #26036. I added clarification to the Callback documentation page explaining how to "turn off" default callbacks using
TrainerArguments.report_to
.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr @pacman100