[Mistral] Mistral-7B-v0.1 support #26447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
Sep 27, 2023
Comment on lines
+25
to
+30
| Mistral-7B-v0.1 is a decoder-based LM with the following architectural choices: | ||
| * Sliding Window Attention - Trained with 8k context length and fixed cache size, with a theoretical attention span of 128K tokens | ||
| * GQA (Grouped Query Attention) - allowing faster inference and lower cache size. | ||
| * Byte-fallback BPE tokenizer - ensures that characters are never mapped to out of vocabulary tokens. | ||
|
|
||
| We also provide an instruction fine-tuned model: `Mistral-7B-Instruct-v0.1` which can be used for chat-based inference. |
There was a problem hiding this comment.
Would be awesome to have more details about the model directly here like the data it was trained on, but it's a nit!
|
|
||
| class MistralAttention(nn.Module): | ||
| """ | ||
| Multi-headed attention from 'Attention Is All You Need' paper. Modified to use sliding window attention |
There was a problem hiding this comment.
Last nit, is there a link to a doc/article/blog where the window attention is introduced? 🤗
1 task
|
Failing test is expected, you can add the failed on setup with "worker 'gw0' crashed while running 'src/transformers/models/mistral/configuration_mistral.py::transformers.models.mistral.configuration_mistral.MistralConfig'"
worker 'gw0' crashed while running 'src/transformers/models/mistral/configuration_mistral.py::transformers.models.mistral.configuration_mistral.MistralConfig'is just from trying to init a too big model for the runner! (Llama also had this issue) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* [Mistral] Mistral-7B-v0.1 support * fixing names * slightly longer test * fixups * not_doctested * wrongly formatted references * make fixuped --------- Co-authored-by: Timothee Lacroix <t@eugen.ai> Co-authored-by: timlacroix <t@mistral.ai>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* [Mistral] Mistral-7B-v0.1 support * fixing names * slightly longer test * fixups * not_doctested * wrongly formatted references * make fixuped --------- Co-authored-by: Timothee Lacroix <t@eugen.ai> Co-authored-by: timlacroix <t@mistral.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for Mistral 7B models
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.